-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Redfish API for following operation #819
base: master
Are you sure you want to change the base?
Added Redfish API for following operation #819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maramsmurthy Thanks for the PR, few things to change
- no need of new testcase, add code in existing MachineConfg.py
- this is config set so values to be set is passed as key value pair by user iocapacity=12 and code sets it and validate
- add the code inside Class CecConfig
- make sure you move the methods to set and get iocapcity inside CecConfig class
- if iocapcity param is not given.. than do nothing
Please upload the logs |
@maramsmurthy Please push the latest code |
10c385b
to
50b7c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maramsmurthy split commit in at least two commit as that will good to have logical code changes history
6f0e2f1
to
28d5f1c
Compare
Console output when test was executed(EBMC - rainier) |
@maramsmurthy Please rebase the code |
20240510100708296825.debug.log debug log file |
if self.bmc_type == "FSP_PHYP": elif self.bmc_type == "EBMC": |
28d5f1c
to
198e561
Compare
@maramsmurthy the code is outdated again,.. looks like unrelated files/changes are part of your PR.. please recheck https://github.com/open-power/op-test/pull/819/files |
babbaef
to
f10437f
Compare
Reading a BIOS attribute using Redfish API Set value to BIOS attribute using Redfish API IOEnlarger capacity BIOS attribute can be updated and read Added call for FSP to set IO enlarge capacity value Signed-off-by: Maram Srimannarayana Murthy <msmurthy@linux.vnet.ibm.com>
f10437f
to
10d3113
Compare
'iocapacity=[0-9]+', str(self.machine_config))[0].split('=')[1] | ||
elif self.bmc_type == "FSP_PHYP:" | ||
ioenlargecapacity = re.findall( | ||
'iocapacity=[0-9]+', str(self.machine_config))[0].split('=')[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why if else needed as in both case logic same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, Will update it as suggested
elif self.bmc_type == "FSP_PHYP": | ||
self.cv_ASM = OpTestASM(self.args.bmc_ip, | ||
self.args.bmc_username, | ||
self.args.bmc_password) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not feel a need to instantiate the object explicitly, as when the cv_System objects is intanstiated.. you get cv_FSP and you can use the same object to call self.cv_FSP.configure_enlarged_io() which will internal created the cv_ASM object.. try this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also similarly we can use self.cv_BMC.io_enlarge_capacity() can be directly used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Trying to allign the code to work with both bmc and FSP
@@ -494,6 +519,11 @@ def CecSetup(self): | |||
self.lmb_setup() | |||
if self.cec_dict['hugepages'] is not None: | |||
self.hugepage_16gb_setup() | |||
if self.cec_dict['iocapacity'] is not None: | |||
if bmc_type == "EBMC_PHYP": | |||
self.io_enlarge_cpacity() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also similarly we can use self.cv_BMC.io_enlarge_capacity() can be directly used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, WIll address this as suggested
@maramsmurthy any update here? |
Reading a BIOS attribute using Redfish API
Set value to BIOS attribute using Redfish API
IOEnlarger capacity BIOS attribute can be update and read using BMCRedFish.py