Issue #682,#688 - Bug: Actions workflow pushes docker images to GitHub con… #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakep7
force-pushed
the
dev-ghcr-update
branch
2 times, most recently
from
d028eda
to
4f3a112
Compare
|
Added a new step to check and ensure that all repository environment variables and secrets are set before running the workflow. |
bencourliss
requested changes
Jul 11, 2023
…s docker images to GitHub container registry, Stop pushing semantic version to dockerhub, CI Workflow failing due to Docker update step. Signed-off-by: blakep7 <pearsonblake9@gmail.com>
blakep7
changed the title
bencourliss
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tainer registry, Stop pushing semantic version to dockerhub, Bug: CI Workflow failing due to Docker update step.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Necessary Repository Settings
Found in: Repo Settings -> Actions -> General
Read and write permissionsshould be selected here, this gives our ephemeralGITHUB_TOKENdefault secret access to push to ghcr.Fixes #682
Fixes #688