Add optional prometheus feature
#220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocm-ci-robot-0
added
the
reviewed/ok-to-test
ocm-ci-robot-0
added
needs/ok-to-test
and removed
reviewed/ok-to-test
3 tasks
8R0WNI3
force-pushed
the
8R0WNI3-prometheus
branch
from
42f2bcb
to
da3b3af
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
- adds external `prometheus` resource to component descriptor - enables optional `prometheus` feature by passing `--prometheus` argument - if the feature is enabled, it will expose an additional `/metrics` endpoint which can be scraped by Prometheus - Prometheus endpoint will be available under `<delivery-service-url>/prometheus` - by now, 3 metrics are going to be monitored: -> `request_latency_seconds` -> `requests_in_progress_total` -> `requests_total`
8R0WNI3
force-pushed
the
8R0WNI3-prometheus
branch
from
da3b3af
to
27b16c2
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
ccwienk
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
prometheusresource to component descriptorprometheusfeature by passing--prometheusargument/metricsendpoint which can be scraped by Prometheus<delivery-service-url>/prometheus->
request_latency_seconds->
requests_in_progress_total->
requests_totalWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: