Configure url and cabundle for self managed cluster #135
Conversation
tamalsaha
force-pushed
the
self-approve
branch
3 times, most recently
from
68321f9
to
ff48f9a
Compare
| if err != nil { | ||
| return err | ||
| } | ||
| apiserverURL, err := helpers.GetAPIServer(kubeClient) |
There was a problem hiding this comment.
Maybe copy the methods from clusteradm repo. I feel it is a little heavy to depend on clusteradm repo only for util. What do you think?
There was a problem hiding this comment.
I can copy it. Will it make sense to move this common methods to the sdk-go repo? If so, what package path will make sense? If not, I can copy the code here.
There was a problem hiding this comment.
yes, make sense to move to sdk-go
There was a problem hiding this comment.
PTAL open-cluster-management-io/sdk-go#23
Once that is merged, I can update both here and in the clusteradm repo.
tamalsaha
force-pushed
the
self-approve
branch
2 times, most recently
from
df73f81
to
4a7e248
Compare
Signed-off-by: Tamal Saha <tamal@appscode.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, tamalsaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 67c9200
into
open-cluster-management-io:main
Without this fix, addons do not work in self managed cluster.