Use lates ocm library and some refactor #110
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @skeeey |
|
This should also fix the missing patch permission open-cluster-management-io/ocm#190 |
| clusterInformers.Cluster().V1beta2().ManagedClusterSets(), | ||
| controllerContext.EventRecorder, | ||
| if features.HubMutableFeatureGate.Enabled(ocmfeature.ManifestWorkReplicaSet) { | ||
| go workhub.RunControllerManagerWithInformers( |
There was a problem hiding this comment.
This also will enable the work hub controller (ManifestWorkReplicaSet)
FYI @tamalsaha
|
@skeeey: GitHub didn't allow me to request PR reviews from the following users: tamalsaha. Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@qiujian16 there are some unused and errcheck in the verify steps |
Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
seems there is some flaky in e2e, retesting passed. |
|
/lgtm |
openshift-merge-robot
merged commit 43603df
into
open-cluster-management-io:main
No description provided.