Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CTS bugs in Sysman Device module #69

Merged
merged 10 commits into from
Oct 16, 2024
Merged

fix: CTS bugs in Sysman Device module #69

merged 10 commits into from
Oct 16, 2024

Conversation

vishnu-khanth
Copy link
Contributor

Related-To: VLCLJ-2272

@vishnu-khanth
fix: CTS bugs in Sysman Device module
5edba50 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
harinik124
harinik124 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@harinik124 harinik124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@vishnu-khanth
fix: CTS bugs in Sysman Device module
8694036 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
pratikbariintel
pratikbariintel previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@pratikbariintel pratikbariintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@vishnu-khanth vishnu-khanth marked this pull request as draft September 12, 2024 11:06
@vishnu-khanth vishnu-khanth marked this pull request as ready for review October 7, 2024 10:58
@vishnu-khanth
fix: CTS bugs in Sysman Device module
f93903a 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
fix: CTS bugs in Sysman Device module
c4b365b 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
fix: CTS bugs in Sysman Device module
11964ca 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
Copy link
Contributor Author

vishnu-khanth commented Oct 8, 2024 •
edited
Loading

The approach followed :

  1. Add events before and after the launch kernel in command list.
  2. Check for Engine type between those two events. 
    • If it's updated, then test passes.

    • Else, check for engine type after workload completion with timeout of 10 seconds. If updated within timeout, test passes with a warning message (Workaround)

@vishnu-khanth
Copy link
Contributor Author

vishnu-khanth commented Oct 8, 2024 •
edited
Loading

This CTS will be revisited & workaround will be removed once the GetProcessState API is fixed/debugged. With this workaround fix test is passing consistently.

@vishnu-khanth
fix: CTS bugs in Sysman Device module
0a222ac 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
fix: CTS bugs in Sysman Device module
ac3ea97 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
fix: CTS bugs in Sysman Device module
3413fe4 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
fix: CTS bugs in Sysman Device module
6985a53 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
fix: CTS bugs in Sysman Device module
afd6001 
Related-To: VLCLJ-2272

Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
Copy link
Contributor Author

vishnu-khanth commented Oct 16, 2024 •
edited
Loading

FYI, the workaround has been removed.
Now the test is passing consistently in platforms where KMD updates the process state correctly.
Failing consistently in platforms where KMD doesn't update process state correctly.

@AshwinKumarKulkarni AshwinKumarKulkarni merged commit 32527cc into oneapi-src:master Oct 16, 2024
13 checks passed
@vishnu-khanth vishnu-khanth deleted the process_state_cts_fix branch October 17, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviralni aviralni aviralni left review comments

@joshuaranjan joshuaranjan joshuaranjan approved these changes

@AshwinKumarKulkarni AshwinKumarKulkarni AshwinKumarKulkarni approved these changes

@harinik124 harinik124 harinik124 approved these changes

@pratikbariintel pratikbariintel pratikbariintel left review comments

@bellekal bellekal Awaiting requested review from bellekal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vishnu-khanth @joshuaranjan @AshwinKumarKulkarni @pratikbariintel @aviralni @harinik124