Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not "add OBO shorthands" to the RO mirror. #3359

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

gouttegd
Copy link
Collaborator

@gouttegd gouttegd commented Sep 9, 2024

RO is currently mirrored in Uberon using a custom rule that bypasses the normal ODK mirroring rule to include an additional step, the addition of OBO shorthands to RO relations.

"OBO shorthands" are basically a trick allowing to use, e.g. part_of instead of BFO:0000050 in a class expression, as in:

relationship: part_of UBERON:00000033

However there is no reason to forcefully inject OBO shorthands to all RO relations as we are currently doing. We can already create OBO shorthands as needed within uberon-edit, for the relationships that are actually used. For example, we already have this in uberon-edit:

[Typedef]
id: part_of
name: part of
xref: BFO:0000050

which creates the part_of shorthand for BFO:0000050.

We should stick to doing that for the relations we are actually using, and stop injectinf fabricated shorthands for the entirety of RO. If people believe that all RO relations should have OBO shorthands, then they should ask the RO folks to add them at the source. It's not Uberon's job to do it.

So this commit removes the rule that adds the OBO shorthands to the RO mirror, so that RO is now mirrored using the standard ODK-generated rule.

closes #3016

RO is currently mirrored in Uberon using a custom rule that bypasses the
normal ODK mirroring rule to include an additional step, the addition of
OBO shorthands to RO relations.

"OBO shorthands" are basically a trick allowing to use, e.g. `part_of`
instead of `BFO:0000050` in a class expression, as in:

  relationship: part_of UBERON:00000033

However there is no reason to forcefully inject OBO shorthands to all RO
relations as we are currently doing. We can already create OBO
shorthands as needed within uberon-edit, for the relationships that are
actually used. For example, we already have this in uberon-edit:

  [Typedef]
  id: part_of
  name: part of
  xref: BFO:0000050

which creates the `part_of` shorthand for BFO:0000050.

We should stick to doing that for the relations we are actually using,
and stop injectinf fabricated shorthands for the entirety of RO. If
people believe that all RO relations should have OBO shorthands, then
they should ask the RO folks to add them at the source. It's not
Uberon's job to do it.

So this commit removes the rule that adds the OBO shorthands to the RO
mirror, so that RO is now mirrored using the standard ODK-generated
rule.

closes #3016
@gouttegd gouttegd self-assigned this Sep 9, 2024
@gouttegd gouttegd added the tech label Sep 9, 2024
@gouttegd gouttegd merged commit ae3f2f8 into master Oct 8, 2024
1 check passed
@gouttegd gouttegd deleted the 3016-dont-add-obo-shorthands-to-ro-mirror branch October 8, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of OBO shorthands to the RO mirror: to preserve?
2 participants