Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release diff poster #1732

Merged
merged 19 commits into from
Jul 21, 2023
Merged

Release diff poster #1732

merged 19 commits into from
Jul 21, 2023

Conversation

shawntanzk
Copy link
Contributor

@shawntanzk shawntanzk commented Nov 16, 2022

requirement:
Release should post a diff src/ontology/diffs/cl-diff.md

@matentzn - is there a set way to configure release to output cl-diff.md (think uberon does this)

requirement:
Release should post a diff src/ontology/diffs/cl-diff.md
@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontologies are identical

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontologies are identical

@github-actions
Copy link

github-actions bot commented Nov 17, 2022

@matentzn
Copy link
Contributor

matentzn commented Nov 17, 2022

@dosumis
Copy link
Contributor

dosumis commented Jan 6, 2023

@shawntanzk to fix soon if poss. Otherwise @anitacaron will take over.

@shawntanzk shawntanzk removed their assignment Jan 19, 2023
@ubyndr
Copy link
Contributor

ubyndr commented Mar 6, 2023

ODK issue should be blocked by this one, shouldn't it? We generally test actions on CL or Uberon then we add them to ODK? @matentzn

@ghost
Copy link

ghost commented Apr 28, 2023

Hi, @anitacaron, is this draft PR still relevant?
If so, can it move forward?
If not, can it be closed?

@anitacaron
Copy link
Contributor

@bvarner-ebi, Yes, I'll update it soon.

@anitacaron
Copy link
Contributor

The diff file is always too big to fit in the limited characters commentary box (65536 characters). The current diff file has 405117 characters.

I suggest adding a link to the diff file instead.

@anitacaron anitacaron marked this pull request as ready for review July 20, 2023 15:53
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I can see that is odd at first sight is that the comment.md path is different in both subtasks, but I am sure you tested this so ok! Nice!

@anitacaron
Copy link
Contributor

Yeah, it works like this. The comment is here

@anitacaron anitacaron merged commit 85e9937 into master Jul 21, 2023
2 checks passed
@anitacaron anitacaron deleted the release-diff-poster-action branch September 29, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants