-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release diff poster #1732
Release diff poster #1732
Conversation
requirement: Release should post a diff src/ontology/diffs/cl-diff.md
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontologies are identical |
Here's a diff of your edit file (unreasoned)Ontologies are identical |
@shawntanzk to fix soon if poss. Otherwise @anitacaron will take over. |
ODK issue should be blocked by this one, shouldn't it? We generally test actions on CL or Uberon then we add them to ODK? @matentzn |
Hi, @anitacaron, is this draft PR still relevant? |
@bvarner-ebi, Yes, I'll update it soon. |
The diff file is always too big to fit in the limited characters commentary box (65536 characters). The current diff file has 405117 characters. I suggest adding a link to the diff file instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I can see that is odd at first sight is that the comment.md
path is different in both subtasks, but I am sure you tested this so ok! Nice!
Yeah, it works like this. The comment is here |
requirement:
Release should post a diff src/ontology/diffs/cl-diff.md
@matentzn - is there a set way to configure release to output cl-diff.md (think uberon does this)