Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Java 8 Support #72

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Jun 11, 2024

We need to support Java 8. jeo-maven-plugin and opeo-maven-plugin use ineo-maven-plugin and they support Java 8.
Since the plugins depends on ineo-maven-plugin they require from ineo-maven-plugin to support Java 8 as well.


PR-Codex overview

This PR adds support for Java 8 alongside existing versions in the Maven build workflow. It also updates Java and plugin versions, compiler settings, and dependencies.

Detailed summary

  • Added Java 8 support in the Maven build workflow
  • Updated Java and plugin versions
  • Modified compiler settings in pom.xml
  • Updated dependencies versions in the project

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo volodya-lombrozo marked this pull request as ready for review June 13, 2024 11:41
@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you take a look, please?

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Reminder

@maxonfjvipon
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 14, 2024

@rultor merge

@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3484e6b into objectionary:master Jun 14, 2024
11 checks passed
@rultor
Copy link
Collaborator

rultor commented Jun 14, 2024

@rultor merge

@maxonfjvipon Done! FYI, the full log is here (took me 25min)

@maxonfjvipon
Copy link
Member

@volodya-lombrozo thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants