-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sonar reliability issues #3241
Merged
yegor256
merged 10 commits into
objectionary:master
from
c71n93:2251-fixing-sonar-violations
Jul 29, 2024
Merged
Fix sonar reliability issues #3241
yegor256
merged 10 commits into
objectionary:master
from
c71n93:2251-fixing-sonar-violations
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n from assertThrows
@yegor256 could you check this one, please? |
1 similar comment
@yegor256 could you check this one, please? |
@yegor256 could you please check this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2251
Check current reliability issues in recent sonar report
They should be fixed in this pull request (except for issues with removing static "ThreadLocal" variables). Check sonar report for test branch in my fork (exact copy of this branch with changes for running sonar in my local repo).
PR-Codex overview
This PR focuses on removing memory leaks by calling
ThreadLocal#remove()
on specific variables.Detailed summary
PhDefault
,PhTraced
,Dataized
classes to include@todo
for memory leak prevention.OnDefault
to handle emptylabel()
.DcsFake
to userand.nextInt(Integer.MAX_VALUE)
instead ofMath.abs(rand.nextInt())
.PullMojoTest
to useFakeMaven
for better readability.