#1428 Add timestamps for logs #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(objectionary#1428): add simple log4j configuration feat(objectionary#1428): add test for log message format feat(objectionary#1428): adjust test format with desired format feat(objectionary#1428): implement the correct logging test feat(objectionary#1428): fix all qulice suggestions feat(objectionary#1428): use log4j.properties instead log4j.xml feat(objectionary#1428): fix dependencies
volodya-lombrozo
force-pushed
the
1428
branch
from
98cb5a4
to
9d3a7b0
Compare
volodya-lombrozo
changed the title
volodya-lombrozo
force-pushed
the
1428
branch
from
045a283
to
7ff1ec8
Compare
feat(objectionary#1428): simplify log4.properties files feat(objectionary#1428): declare dependencies in a more straigtforward way feat(objectionary#1428): use OS independent line separator
volodya-lombrozo
force-pushed
the
1428
branch
from
7ff1ec8
to
81a4d80
Compare
|
@mximp pls, take a look |
mximp
approved these changes
Nov 11, 2022
|
@yegor256 merge please |
yegor256
reviewed
Nov 11, 2022
| @@ -2,10 +2,10 @@ log4j.rootLogger=WARN, CONSOLE | |||
|
|
|||
| log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender | |||
| log4j.appender.CONSOLE.layout=com.jcabi.log.MulticolorLayout | |||
| log4j.appender.CONSOLE.layout.ConversionPattern=[%color{%p}] %c: %m%n | |||
| log4j.appender.CONSOLE.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss} [%color{%p}] %c: %m%n | |||
There was a problem hiding this comment.
@volodya-lombrozo do we really need a year in tests? :) I think mm:ss is more than enough.
There was a problem hiding this comment.
@yegor256 fixed. I've left only HH:mm:ss. If we leave only mm:ss - it will confuse, because looks like HH:mm
yegor256
reviewed
Nov 11, 2022
| @@ -2,7 +2,7 @@ log4j.rootLogger=WARN, CONSOLE | |||
|
|
|||
| log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender | |||
| log4j.appender.CONSOLE.layout=com.jcabi.log.MulticolorLayout | |||
| log4j.appender.CONSOLE.layout.ConversionPattern=[%color{%p}] %c: %m%n | |||
| log4j.appender.CONSOLE.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss} [%p] %c: %m%n | |||
There was a problem hiding this comment.
@volodya-lombrozo same here, why year/month/day?
There was a problem hiding this comment.
@yegor256 fixed. I've left only HH:mm:ss. If we leave only mm:ss - it will confuse, because looks like HH:mm
yegor256
reviewed
Nov 11, 2022
| log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout | ||
| log4j.appender.CONSOLE.layout.ConversionPattern=BUILD %c: %m%n | ||
| log4j.appender.CONSOLE.layout=com.jcabi.log.MulticolorLayout | ||
| log4j.appender.CONSOLE.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss} [%color{%p}] %c: %m%n |
There was a problem hiding this comment.
@volodya-lombrozo same here, why year/month/day?
There was a problem hiding this comment.
@yegor256 fixed. I've left only HH:mm:ss. If we leave only mm:ss - it will confuse, because looks like HH:mm
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timestamps for
log4jlogger configuration and provided tests in order to prove that the new format is actually working.Closes: #1428
That PR adds timestamps only for
log4jlogs, that is useful for testing purposes. In order to add timestamps for maven build process we have to implement the next issue: objectionary/eoc#94