Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert support to solar UI locales #4111

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

SultanSagi
Copy link
Contributor

@SultanSagi SultanSagi commented Oct 3, 2024

Related to: AUT-3674

Description:
Rollback any FE change related to New Terminlogy
Check rollback FE changes from https://github.com/oat-sa/tao-core/pull/4053/files

Changes:

  • Remove terminology maps with new translations

How to check:
Start the containers:
taoDockerize up

Install composer packages.
taoDockerize composer install --prefer-source

Install TAO
taoDockerize install

Run commands:

php tao/scripts/taoTranslate.php -v -a=create -e=taoQtiItem -l=es-ES
php tao/scripts/taoTranslate.php -v -a=update -e=taoQtiItem -l=es-ES
php tao/scripts/taoTranslate.php -v -a=compile -e=taoQtiItem -l=es-ES

Copy link

github-actions bot commented Oct 3, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
161 161 0 0

Copy link

github-actions bot commented Oct 4, 2024

Version

Target Version 54.22.5
Last version 54.22.4

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

@SultanSagi SultanSagi marked this pull request as ready for review October 4, 2024 06:41
@SultanSagi SultanSagi requested a review from pribi October 4, 2024 06:41
@pribi
Copy link
Contributor

pribi commented Oct 8, 2024

Checked with local NGS

Before:
image

b5be539931a1:/var/www/html# php tao/scripts/taoTranslate.php -v -a updateall -e taoQtiItem
Xdebug: [Step Debug] Could not connect to debugging client. Tried: host.docker.internal:9003 (through xdebug.client_host/xdebug.client_port).

Deprecated: Optional parameter $params declared before required parameter $driver is implicitly treated as a required parameter in /var/www/html/generis/common/persistence/class.Persistence.php on line 66
* Running tao/scripts/taoTranslate.php
Languages 'ar-SA,ar-arb,da-DK,de-AT,de-BE,de-CH,de-DE,de-LI,de-LU,el-GR,en-GB,en-US,es-ES,es-MX,fi-FI,fr-BE,fr-CA,fr-CH,fr-FR,fr-LU,fr-QC,he-IL,hu-HU,id-ID,is-IS,it-IT,ja-HS,ja-JP,ja-LE,ja-UE,lb-LU,lt-LT,nb-NO,ne-NP,nl-BE,nl-NL,nl-SR,nn-NO,no-NO,pl-PL,pt-BR,pt-PT,ru-RU,sk-SK,sv-SE,uk-UA,zh-CN,zh-SG,zh-TW' will be updated for extension 'taoQtiItem'.
Updating language 'ar-SA-S' for extension 'taoQtiItem'...

Deprecated: SimpleXMLElement::__construct(): Passing null to parameter #2 ($options) of type int is deprecated in /var/www/html/tao/helpers/translation/class.StructureExtractor.php on line 52
3 units extracted from structures.xml.

Fatal error: Uncaught tao_helpers_translation_TranslationException: The translation file '/var/www/html/tao/scripts/../../taoQtiItem/locales/ar-SA-S/messages.po' does not exist. in /var/www/html/tao/helpers/translation/class.POFileReader.php:57
Stack trace:
#0 /var/www/html/tao/scripts/class.TaoTranslate.php(712): tao_helpers_translation_POFileReader->read()
#1 /var/www/html/tao/scripts/class.TaoTranslate.php(819): tao_scripts_TaoTranslate->actionUpdate()
#2 /var/www/html/tao/scripts/class.TaoTranslate.php(196): tao_scripts_TaoTranslate->actionUpdateAll()
#3 /var/www/html/tao/scripts/class.Runner.php(121): tao_scripts_TaoTranslate->run()
#4 /var/www/html/tao/scripts/class.TaoTranslate.php(141): tao_scripts_Runner->__construct(Array, Array)
#5 /var/www/html/tao/scripts/taoTranslate.php(34): tao_scripts_TaoTranslate->__construct(Object(oat\tao\helpers\translation\SolarThemeHelper), Array)
#6 {main}
  thrown in /var/www/html/tao/helpers/translation/class.POFileReader.php on line 57

After:
output.webm

@tikhanovichA tikhanovichA self-requested a review October 8, 2024 14:29
Copy link
Contributor

@tikhanovichA tikhanovichA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@SultanSagi SultanSagi merged commit 909411b into develop Oct 9, 2024
6 checks passed
@SultanSagi SultanSagi deleted the fix/AUT-3674/revert-solar-locales branch October 9, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants