Breaking/tdr 9/handlebars 4 upgrade #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krampstudio
reviewed
Jan 8, 2020
…e_with-partials fix partials
…ing/TDR-9/handlebars-4-upgrade
Coverage Report
|
olga-kulish
reviewed
Aug 25, 2023
| {{#if ../../disabled}} disabled="disabled"{{/if}}> | ||
| {{#if ../../icon}}<span class="icon-{{../../../icon}}"></span>{{/if}} | ||
| {{../../label}} | ||
| {{#with row}} |
There was a problem hiding this comment.
This #with is needed, because action.hidden is expected to be a function with reference to row as this:
actions: [{
id: 'action-1',
hidden: function() {
this.userFirstName === 'nobody'
}
}]
Version❕ Some commits are not using the conventional commits formats. They will be ignored in version management.
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/TR-3264
https://oat-sa.atlassian.net/wiki/spaces/FOUN/pages/144081031/Upgrade+Handlebars
The majority of the work to upgrade Handlebars ended up occurring in
tao-core-ui.TODO
MASTER LIST OF RELATED PRs (in order of merging)
libraries
main extensions
PCI extensions
TAO Advance