-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add front-end tests #517
Conversation
fc89957
to
cbddb59
Compare
7140866
to
1e134d2
Compare
45f365a
to
c99d243
Compare
a92cea7
to
a3280cb
Compare
Back-end summary PHP 8.1
|
Back-end summary PHP 8.0
|
Back-end summary PHP 7.4
|
Front-end summary Node 18
|
a3280cb
to
40aca29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on getting FE tests to fully run, and improving the pipeline again!
If you want to stop at this version I don't mind, but if we would spend an extra day or so we could modify the grunt files in tao-core so it can get the good puppeteer args for this environment in a regular way?
if: ${{ matrix.node-version }} | ||
working-directory: tao/views/build | ||
run: | | ||
perl -0777 -pi -e "s/(puppeteer[\s\r\n]*:[\s\r\n]*.*args:[\s\r\n]+\[)/\1'--disable-dev-shm-usage','--disable-setuid-sandbox','--single-process',/s" grunt/test.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a saner way to set some args, than editing a file on the fly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure :)
In fact, I noticed only later that the flags I added probably do not make much of a difference. Let me try to execute the workflow without this ugly line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
The run was successful without these flags as well. So, while they could be adding to stability of the tests, I guess we can live without this ugly hack.
40aca29
to
837c2d3
Compare
FUN-965
This PR enables client-side test and includes them into the report publication.
See https://github.com/oat-sa/tao-community/actions/runs/5544605113/jobs/10122308704#step:11:444 and #517 (comment).