Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add front-end tests #517

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Conversation

wazelin
Copy link
Member

@wazelin wazelin commented Jul 13, 2023

FUN-965

This PR enables client-side test and includes them into the report publication.

See https://github.com/oat-sa/tao-community/actions/runs/5544605113/jobs/10122308704#step:11:444 and #517 (comment).

Execution Time (2023-07-13 14:55:02 UTC-0)
loading tasks                   1.1s  ▇ 2%
qunit:qtiitempcitest            4.2s  ▇▇ 6%
qunit:taotest                  11.6s  ▇▇▇▇▇▇ 17%
qunit:taoclientdiagnostictest   3.2s  ▇▇ 5%
qunit:taodeliveryrdf           833ms  ▇ 1%
qunit:taoitemstest             873ms  ▇ 1%
qunit:taomediamanagertest       2.1s  ▇ 3%
qunit:taoqtiitemtest           19.5s  ▇▇▇▇▇▇▇▇▇ 28%
qunit:taoqtitest                6.7s  ▇▇▇▇ 10%
qunit:taoqtitestpreviewer      15.7s  ▇▇▇▇▇▇▇▇ 23%
qunit:taotaskqueuetest          1.6s  ▇ 2%
Total 1m 9.1s

@wazelin wazelin force-pushed the feature/FUN-965/add-front-end-tests branch 2 times, most recently from fc89957 to cbddb59 Compare July 13, 2023 11:35
@wazelin wazelin force-pushed the feature/FUN-965/add-front-end-tests branch 2 times, most recently from 7140866 to 1e134d2 Compare July 13, 2023 13:01
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@wazelin wazelin force-pushed the feature/FUN-965/add-front-end-tests branch from 45f365a to c99d243 Compare July 13, 2023 13:41
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@wazelin wazelin force-pushed the feature/FUN-965/add-front-end-tests branch 8 times, most recently from a92cea7 to a3280cb Compare July 13, 2023 14:43
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@oat-sa oat-sa deleted a comment from github-actions bot Jul 13, 2023
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Back-end summary PHP 8.1

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
1816 1803 13 0

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Back-end summary PHP 8.0

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
3516 3494 22 0

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Back-end summary PHP 7.4

🔗 Coverage report

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
3516 3494 22 0

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
1814 1814 0 0

Copy link

@kilatib kilatib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on getting FE tests to fully run, and improving the pipeline again!

If you want to stop at this version I don't mind, but if we would spend an extra day or so we could modify the grunt files in tao-core so it can get the good puppeteer args for this environment in a regular way?

if: ${{ matrix.node-version }}
working-directory: tao/views/build
run: |
perl -0777 -pi -e "s/(puppeteer[\s\r\n]*:[\s\r\n]*.*args:[\s\r\n]+\[)/\1'--disable-dev-shm-usage','--disable-setuid-sandbox','--single-process',/s" grunt/test.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a saner way to set some args, than editing a file on the fly!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure :)

In fact, I noticed only later that the flags I added probably do not make much of a difference. Let me try to execute the workflow without this ugly line.

Copy link
Member Author

@wazelin wazelin Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

The run was successful without these flags as well. So, while they could be adding to stability of the tests, I guess we can live without this ugly hack.

@wazelin wazelin force-pushed the feature/FUN-965/add-front-end-tests branch from 40aca29 to 837c2d3 Compare July 14, 2023 07:41
@wazelin wazelin requested a review from oatymart July 14, 2023 07:53
@wazelin wazelin merged commit 2e24039 into master Jul 14, 2023
4 checks passed
@wazelin wazelin deleted the feature/FUN-965/add-front-end-tests branch July 14, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants