Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Metadata exporter gather list from property without range #2504

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Prevent Metadata exporter gather list from property without range #2504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bea0cc
fix: This will prtect from exporting properties that don't have range
bartlomiejmarszal Sep 12, 2024
cef7e63
fix: PropertyMapperTest
bartlomiejmarszal Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/classes/metadata/metaMetadata/PropertyMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function getMetadataProperties(Property $property): array

private function isIgnoredForCollectionGathering(Property $property): bool
{
return in_array($property->getUri(), $this->getIgnoredProperties());
return in_array($property->getUri(), $this->getIgnoredProperties()) || $property->getRange() === null;
}

private function getIgnoredProperties(): array
Expand Down
1 change: 1 addition & 0 deletions test/unit/models/classes/metadata/metaMetadata/PropertyMapperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public function testGetMetadataProperties(): void
$property = $this->createMock(Property::class);
$resourceMock = $this->createMock(Resource::class);
$property->method('getUri')->willReturn('uri');
$property->method('getRange')->willReturn('range');
$resourceMock->method('getUri')->willReturn('resource_uri');

$property
Expand Down
Loading