Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/AUT-3414/Align categories that activate the TextToSpeech tool #2461

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Apr 16, 2024

Related to: https://oat-sa.atlassian.net/browse/AUT-3414

Requires:

Summary

Add support for multiple categories to activate presets in the test authoring.
The concepts is as follows:

  • a preset can be activated using any of the declared categories (support for legacy categories)
  • when saving the test, only the main declared category of the preset is persisted

The main example for this is the text-to-speech tool which used to be activated using the category x-tao-option-textToSpeech. However, TAO Advance expects it to be x-tao-option-tts. Both categories will be supported, but only the later will be kept when updating a test.

How to test

Prerequisite: have the extension taoTextHelp installed with the branch feature/AUT-3414/align-tts-category

  • create/open a test in Authoring
  • activate the test taker tool TextToSpeech
  • save the changes
  • export the test, then open the archive an check that the category x-tao-option-textToSpeech is set appropriately
  • check out the branch on both taoQtiTest and taoTextHelp: git checkout -t origin/feature/AUT-3414/align-tts-category
  • update TAO
  • open the same test in Authoring
  • check that the taker tool TextToSpeech is still activated
  • deactivate the tool, then activate it again
  • save the changes
  • export the test, then open the archive an check that the category x-tao-option-tts is set appropriately

Copy link

github-actions bot commented Apr 16, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
708 708 0 0

@jsconan jsconan requested a review from gabrielfs7 April 17, 2024 06:44
Copy link

Version

Target Version 48.4.0
Last version 48.3.7

There are 0 BREAKING CHANGE, 2 features, 0 fix

@jsconan jsconan requested a review from gabrielfs7 April 17, 2024 07:15
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the code, @jsconan

I did a check on PHP code level only and looks good. We can have a demo to check functionality if possible.

  • New code is covered by tests (if applicable) JS code is
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsconan jsconan merged commit 8993430 into develop Apr 19, 2024
5 of 6 checks passed
@jsconan jsconan deleted the feature/AUT-3414/align-tts-category branch April 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants