Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: crowdin ar-SA locale merged to ar-arb #2455

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

augustas
Copy link
Collaborator

@augustas augustas commented Apr 11, 2024

Copy link

github-actions bot commented Apr 11, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
708 708 0 0

Copy link

Version

Target Version 48.3.6
Last version 48.3.5

There are 0 BREAKING CHANGE, 0 feature, 0 fix

@progys progys self-requested a review April 12, 2024 12:06
"Project-Id-Version: TAO 2023.12\n"
"PO-Revision-Date: 2023-12-01T07:53:18\n"
"Project-Id-Version: tao-open-source\n"
"PO-Revision-Date: 2023-06-07 09:14\n"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: revision date is older than before, is this fine?

Copy link
Collaborator Author

@augustas augustas Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is okay, only a few labels in this file, both those labels have never been translated for Arabic. Thanks for pointing it out 👍🏻

Copy link

@progys progys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except failing sonar, but seems it is failing for main branch too, so I guess safe to ignore....

@augustas augustas merged commit 17fb785 into develop Apr 12, 2024
5 of 6 checks passed
@augustas augustas deleted the fix/REL-1580/single-arabic-choice branch April 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants