Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing furigana from test authoring #2449

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

KirylHatalski
Copy link
Contributor

@KirylHatalski KirylHatalski commented Mar 14, 2024

Ticket: AUT-3327

What's Changed

  • Ruby tag removed from Rubric Block's CK Editor on Test Authoring

Demo

image

Test Env

test-kiril.playground.kitchen
Creds: admin/admin

How to test

  • Navigate to 'Tests' tab
  • Open the test from preconditions in 'Authoring' mode
  • Click ‘+ New section’ button
  • Click ‘Manage Rubric Blocks' on the right from the section’s name
  • Click '+ New Rubric Block' button
  • Observe CK Editor
  • Enter some text
  • Select entered text and click 'Insert Furigana (Ruby)' button
  • Enter some text
  • Click 'Save' button

Copy link

Version

Target Version 48.3.4
Last version 48.3.3

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
708 708 0 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.02%. Comparing base (06ab2be) to head (875173b).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2449   +/-   ##
==========================================
  Coverage      17.02%   17.02%           
  Complexity      3228     3228           
==========================================
  Files            209      209           
  Lines          11651    11651           
==========================================
  Hits            1983     1983           
  Misses          9668     9668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • [] Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely. Good job!

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@KirylHatalski KirylHatalski merged commit 41c76e5 into develop Mar 15, 2024
5 of 6 checks passed
@KirylHatalski KirylHatalski deleted the fix/AUT-3327/removing_ruby-button-from-test branch March 15, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants