fix: add missing const in metadata exporter implementation #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejmarszal
requested review from
andreluizmachado,
pnal,
Karol-Stelmaczonek,
tikhanovichA and
viktar-dzmitryieu-tao
Front-end summary Node 18
|
bartlomiejmarszal
force-pushed
the
fix/ADF-1634/missing-version-metadata-exporter
branch
from
bfb4d25
to
aaae90c
Compare
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2444 +/- ##
==========================================
Coverage 17.02% 17.02%
Complexity 3228 3228
==========================================
Files 209 209
Lines 11651 11651
==========================================
Hits 1983 1983
Misses 9668 9668 ☔ View full report in Codecov by Sentry. |
tikhanovichA
approved these changes
Feb 21, 2024
siwane
approved these changes
Feb 21, 2024
bartlomiejmarszal
deleted the
fix/ADF-1634/missing-version-metadata-exporter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIssing const in
\oat\taoQtiTest\models\export\Formats\Metadata\TestPackageExportwas causing critical error when creating empty manifest file: in\oat\taoQtiTest\models\QtiTestUtils::emptyImsManifest.Defined const to
metadataThis change does not impact exporter functionality.