Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update methods to lodash 4 version #2431

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

taopkorczak
Copy link
Contributor

Related: https://oat-sa.atlassian.net/browse/ADF-1579

Update lodash methods to version 4.

Copy link

github-actions bot commented Jan 25, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
708 708 0 0

…ash v4

Signed-off-by: Sergei Mikhailov <sergei.mikhailov@taotesting.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (362b82c) 16.88% compared to head (3fde131) 17.02%.
Report is 10 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2431      +/-   ##
=============================================
+ Coverage      16.88%   17.02%   +0.13%     
- Complexity      3222     3228       +6     
=============================================
  Files            209      209              
  Lines          11594    11651      +57     
=============================================
+ Hits            1958     1983      +25     
- Misses          9636     9668      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wazelin wazelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the failing tests tomorrow, @taopkorczak.
And make sure to merge this PR after fixing the tests.

https://github.com/oat-sa/extension-tao-testqti/actions/runs/7744941999/job/21123704626

If the tests are failing for reasons irrelevant to the changes made here, feel free to merge as-is and fix the tests in a follow-up PR.

views/js/testRunner/testMetaData.js Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 2, 2024

Version

Target Version 48.3.2
Last version 48.3.1

There are 0 BREAKING CHANGE, 0 feature, 4 fixes

Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fingers crossed...

@taopkorczak taopkorczak merged commit 4707d6c into develop Feb 2, 2024
5 of 6 checks passed
@taopkorczak taopkorczak deleted the feature/ADF-1579/update-lodash-to-4 branch February 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants