feat: place imported assets to correct class #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2409 +/- ##
==========================================
Coverage 16.71% 16.71%
Complexity 3182 3182
==========================================
Files 207 207
Lines 11453 11453
==========================================
Hits 1914 1914
Misses 9539 9539
☔ View full report in Codecov by Sentry. |
bartlomiejmarszal
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
Karol-Stelmaczonek
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
| @@ -96,6 +96,9 @@ class taoQtiTest_models_classes_QtiTestService extends TestService | |||
| public const XML_TEST_PART = 'testPart'; | |||
| public const XML_ASSESSMENT_SECTION = 'assessmentSection'; | |||
| public const XML_ASSESSMENT_ITEM_REF = 'assessmentItemRef'; | |||
|
|
|||
| private const IN_PROGRESS_LABEL = 'in progress'; | |||
There was a problem hiding this comment.
I think LABEL_IN_PROGESS is better, because then you would just add another LABEL_ and everything would be in same code block
There was a problem hiding this comment.
The text for the label when status is in progress: 'in progress' status label IN_PROGRESS_LABEL
For me sounds more clear than: label for 'in progress' status - more context dropped
bartlomiejmarszal
approved these changes
Oct 4, 2023
pnal
deleted the
feature/PISA25-561/place-imported-assets-to-proper-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/PISA25-561
What's Changed
Related PR: oat-sa/extension-tao-itemqti#2407
How to test
check: oat-sa/extension-tao-itemqti#2407