Fix default route with libnl3.8+ #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupondje
force-pushed
the
fix_default_route
branch
from
18fc753
to
1041dd3
Compare
dupondje
force-pushed
the
fix_default_route
branch
2 times, most recently
from
c27f8a0
to
aa59707
Compare
aesteve-rh
requested changes
Feb 1, 2024
Since libnl3.8, the nl_addr_parse function does not return 'none' anymore for 'default', but it returns a 0.0.0.0/0 addr. thom311/libnl@0c0aee8 But since we depend on that value in vdsm, it never reports a default gateway anymore, causing networks to be out of sync. So next to 'none' we also check for '0.0.0.0/0' or '::/0'. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
dupondje
force-pushed
the
fix_default_route
branch
from
aa59707
to
a85228d
Compare
aesteve-rh
reviewed
Feb 1, 2024
aesteve-rh
approved these changes
Feb 1, 2024
|
/ost |
1 similar comment
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libnl3.8, he nl_addr_parse does not return 'none' anymore for 'default', but it returns a 0.0.0.0/0 addr.
thom311/libnl@0c0aee8
But since we depend on that value in vdsm, it never reported a default gateway anymore, and caused networks to be out of sync.
So next to 'none' we also check for '0.0.0.0/0' or '::/0'.