Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MySQL prepared statements #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CromFr
Copy link
Member

@CromFr CromFr commented Oct 9, 2022

Prepared statements provide a safer (no more string escaping required) and more efficient (if identical statements are called frequently) way of running SQL queries.

This PR defines the prepared statements API for SQL plugins, and implements support for the xp_mysql plugin.

TODO:

  • Check that returned strings are not changed on SQL fetch (i.e. check if it's strcpy-ed or if it retains the pointer to the original data)
  • Check results client-side caching (I'm not sure it's enabled)
  • Try improving performance (currently it's only ~10% faster)
  • Implement for xp_sqlite? (should be fairly straightforward)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant