Add argument to specify path to ROMs #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1386,6 +1394,7 @@ int main(int argc, char *argv[]) | |||
| printf(" -p:<port_number> Set MIDI port.\n"); | |||
| printf(" -a:<device_number> Set Audio Device index.\n"); | |||
| printf(" -ab:<page_size>:[page_count] Set Audio Buffer size.\n"); | |||
| printf(" -d:<rom_path> Set ROM directory.\n"); | |||
| printf("\n"); | |||
| printf(" -mk2 Use SC-55mk2 ROM set.\n"); | |||
There was a problem hiding this comment.
I would maybe separate -d: from the others since directories aren't related to audio. Something like this:
...
-a:<device_number> Set Audio Device index.
-ab:<page_size>:[page_count] Set Audio Buffer size.
-d:<rom_path> Set ROM directory.
-mk2 Use SC-55mk2 ROM set.
-st Use SC-55st ROM set.
...
There was a problem hiding this comment.
Good idea. Changed & force pushed.
|
or you can make directory with rom name and automatic choose the right one when you type --mk1, --jv880 , ... |
Being able to specify the folder via an argument is useful on Linux where the application is usually installed to a location where only the root user has write access too. Ex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new argument
-d:to specify the directory to use for ROMs.