-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: IDFv5.0 Fix mqtt module #3607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Small fixes.
|
Sorry, Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though I'm (still) not in a position to try it out myself.
@@ -419,7 +423,7 @@ static int mqtt_connect(lua_State* L) { | |||
|
|||
ESP_LOGD(TAG, "connect: mqtt_context*: %p", mqtt_context); | |||
|
|||
if (config.broker.address.uri != NULL) | |||
if (config.broker.address.uri == NULL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well oops! 😳 That would be my mistake...
|`mqtt.CONNACK_REFUSED_SERVER_UNAVAILABLE`|3|The server is unavailable.| | ||
|`mqtt.CONNACK_REFUSED_BAD_USER_OR_PASS`|4|The broker refused the specified username or password.| | ||
|`mqtt.CONNACK_REFUSED_NOT_AUTHORIZED`|5|The username is not authorized.| | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't see any reference to these ever having existed in this module. I guess this was an esp8266 leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I found these reason codes only in the mqtt-8266 module.
Thank you for the PR @serg3295 ! Merge has been done! |
dev
branch rather than for therelease
branch.docs/*
.The mqtt module does not work with IDFv5.0
I think an additional user_config checks were added in new espressif/esp-mqtt submodule.
Error log:
This PR fixes that error.