Make supernova-benches an independent workspace #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For a cleaner solution: move exclude = ["supernova-benches"]to Cargo.toml. (because of rust-lang/cargo#6745) Benefits are:
Later, we could change it to exclude = ["benches/*"] |
|
Awesome, thanks for the great explanation @slumber. I've followed through with the proposed fix. |
slumber
reviewed
Jan 20, 2024
supernova-benches/Cargo.lock
Outdated
| @@ -0,0 +1,1611 @@ | |||
| # This file is automatically @generated by Cargo. | |||
There was a problem hiding this comment.
Opposite to the workspace, I believe this one is OK (or rather should) to be excluded.
I wouldn't expect people to always update it along with the main lock file, as it's not going to be done automatically for an excluded crate.
So it's better to add .gitignore to the crate with Cargo.lock
slumber
approved these changes
Jan 21, 2024
guruvamsi-policharla
pushed a commit
that referenced
this pull request
Jan 23, 2024
* make supernova-benches an independent workspace * place supernova-benches at root, and exclude from workspace * rm Cargo.lock from git
guruvamsi-policharla
pushed a commit
that referenced
this pull request
Feb 1, 2024
* make supernova-benches an independent workspace * place supernova-benches at root, and exclude from workspace * rm Cargo.lock from git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can't run
supernova-benches, as it now thinks it is part of the zkVM workspace after the recentsupernova->nexus-zkvmmigration.This fixes this.