Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(autoloader): Remove noisy changes when regenerating #48756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

provokateurin
Copy link
Member

Summary

When executing the script all the app/*/composer/composer/installed.php files change as they reference the current HEAD commit hash. To avoid having to manually discard the changes, just drop them automatically.

Checklist

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added the 3. to review Waiting for reviews label Oct 17, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 17, 2024
@provokateurin provokateurin requested review from a team, ArtificialOwl, artonge and Fenn-CS and removed request for a team October 17, 2024 07:26
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no option to prevent those updates in the first place?
Approved, as fine with this solution thought.

@susnux
Copy link
Contributor

susnux commented Oct 21, 2024

Is there no option to prevent those updates in the first place?

Skip the composer install ... part and only run composer dump-autoload ....

@provokateurin
Copy link
Member Author

Skip the composer install ... part and only run composer dump-autoload ....

I wonder if not doing it could cause any problems. I don't see why we need to do it first before dumping the autoloaders, so we might just get rid of it in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants