fixup! feat: mail snippets

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

appinfo/routes.php

@@ -490,6 +490,41 @@
 			'url' => '/api/follow-up/check-message-ids',
 			'verb' => 'POST',
 		],
+		[
+			'name' => 'snippet#getOwnSnippets',
+			'url' => '/api/snippets',
+			'verb' => 'GET',
+		],
+		[
+			'name' => 'snippet#getSharedSnippets',
+			'url' => '/api/snippets/shared',
+			'verb' => 'GET',
+		],
+		[
+			'name' => 'snippet#create',
+			'url' => '/api/snippets',
+			'verb' => 'POST',
+		],
+		[
+			'name' => 'snippet#update',
+			'url' => '/api/snippets',
+			'verb' => 'PUT',
+		],
+		[
+			'name' => 'snippet#delete',
+			'url' => '/api/snippets',
+			'verb' => 'DELETE',
+		],
+		[
+			'name' => 'snippet#share',
+			'url' => '/api/snippets',
+			'verb' => 'POST',
+		],
+		[
+			'name' => 'snippet#deleteShare',
+			'url' => '/api/snippets/share',
+			'verb' => 'DELETE',
+		],
 	],
 	'resources' => [
 		'accounts' => ['url' => '/api/accounts'],

lib/Controller/SnippetController.php

@@ -15,6 +15,7 @@
 use OCA\Mail\Http\TrapError;
 use OCA\Mail\Service\SnippetService;
 use OCP\AppFramework\Controller;
+use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
 use OCP\IRequest;
@@ -96,7 +97,24 @@ public function update(int $snippetId, string $title, string $content): JsonResp
 		return JsonResponse::success($snippet, Http::STATUS_OK);
 	}
 
+	public function delete($snippetId): JsonResponse {
+		try {
+			$this->snippetService->delete($snippetId, $this->uid);
+			return JsonResponse::success();
+		} catch (DoesNotExistException $e) {
+			return JsonResponse::fail('Snippet not found', Http::STATUS_NOT_FOUND);
+		}
+	}
 
+	/**
+	 * @NoAdminRequired
+	 * @param int $snippetId
+	 * @param string $shareWith
+	 * @param string $type
+	 *
+	 * @return JsonResponse
+	 */
+	#[TrapError]
 	public function share(int $snippetId, string $shareWith, string $type): JsonResponse {
 		$snippet = $this->snippetService->find($snippetId, $this->uid);
 
@@ -117,4 +135,24 @@ public function share(int $snippetId, string $shareWith, string $type): JsonResp
 
 	}
 
+	/**
+	 * @NoAdminRequired
+	 * @param int $snippetId
+	 * @param string $shareWith
+	 *
+	 * @return JsonResponse
+	 */
+	#[TrapError]
+	public function deleteShare(int $snippetId, string $shareWith): JsonResponse {
+		$snippet = $this->snippetService->find($snippetId, $this->uid);
+
+		if ($snippet === null) {
+			return JsonResponse::error('Snippet not found', Http::STATUS_NOT_FOUND);
+		}
+
+		$this->snippetService->unshare($snippetId, $shareWith);
+
+		return JsonResponse::success();
+	}
+
 }

lib/Service/SnippetService.php

@@ -49,10 +49,11 @@ public function findAll(string $userId): array {
 
 	/**
 	 * @param string
+	 * @return Snippet[]
 	 */
 	public function findAllSharedWithMe(string $userId): array {
 		$groups = $this->groupManager->getUserGroupIds($userId);
-		return $this->snippetShareMapper->findSharedWithMe($userId, $groups);
+		return $this->snippetMapper->findSharedWithMe($userId, $groups);
 	}
 	/**
 	 * @param int $snippetId
@@ -103,7 +104,13 @@ public function delete(int $snippetId, string $userId): void {
 		$this->snippetMapper->delete($snippet);
 	}
 
-	//TODO: run owner check on controller level
+
+	/**
+	 * @param int $snippetId
+	 * @param string $shareWith
+	 * @throws DoesNotExistException
+	 * @throws NotPermittedException
+	 */
 	public function share(int $snippetId, string $shareWith): void {
 
 		$sharee = $this->userManager->get($shareWith);
@@ -120,6 +127,12 @@ public function share(int $snippetId, string $shareWith): void {
 		$this->snippetShareMapper->insert($share);
 	}
 
+	/**
+	 * @param int $snippetId
+	 * @param string $groupId
+	 * @throws DoesNotExistException
+	 * @throws NotPermittedException
+	 */
 	public function shareWithGroup(int $snippetId, string $groupId): void {
 		if (!$this->groupManager->groupExists($groupId)) {
 			throw new DoesNotExistException('Group does not exist');
@@ -134,6 +147,11 @@ public function shareWithGroup(int $snippetId, string $groupId): void {
 		$this->snippetShareMapper->insert($share);
 	}
 
+	/**
+	 * @param int $snippetId
+	 * @param string $shareWith
+	 * @throws DoesNotExistException
+	 */
 	public function unshare(int $snippetId, string $shareWith): void {
 		$share = $this->snippetShareMapper->find($snippetId, $shareWith);
 		$this->snippetShareMapper->delete($share);