fix(attachmentService, propfindErrorParse): add an error message for when a file is not compatible for windows #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6303 +/- ##
============================================
- Coverage 23.75% 23.73% -0.03%
Complexity 454 454
============================================
Files 246 247 +1
Lines 11718 11731 +13
Branches 2220 2223 +3
============================================
Hits 2784 2784
- Misses 8615 8627 +12
- Partials 319 320 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This is a fix 🙊 This needs a backport too |
…when a file is not compatible for windows Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
GVodyanov
force-pushed
the
enh/add-windows-incompatible-error-message
branch
from
1826bfd
to
d7288b0
Compare
GVodyanov
changed the title
|
/backport to stable5.0 |
backportbot
bot
added
the
backport-request
ChristophWurst
approved these changes
Sep 2, 2024
backportbot
bot
removed
the
backport-request
|
Does this need a backport to stable4.7 as well? |
|
No because nextcloud/server#44963 is for 30+ |
st3iny
reviewed
Sep 4, 2024
|
|
||
| return messageElement?.textContent | ||
| } catch (parseError) { | ||
| console.error(t('spreed', 'Error while parsing a PROPFIND error'), parseError) |
There was a problem hiding this comment.
Should be sourced from calendar instead of spreed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6245
Mostly copied from https://github.com/nextcloud/spreed/blob/main/src/utils/propfindErrorParse.ts