Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fc): tiny white border on highlighted cells #6171

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 16, 2024

Fixes #6139

Before After
image grafik

@st3iny st3iny added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. Feature: Fullcalendar labels Jul 16, 2024
@st3iny st3iny added this to the v5.0.0 milestone Jul 16, 2024
@st3iny st3iny self-assigned this Jul 16, 2024
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/fc/today-white-border branch from fe2ea1f to 1017e40 Compare July 16, 2024 11:18
@st3iny st3iny changed the title fix(fc): tiny white border on today fix(fc): tiny white border on highlighted cells Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.97%. Comparing base (6d1a23d) to head (1017e40).
Report is 28 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6171      +/-   ##
============================================
- Coverage     23.97%   23.97%   -0.01%     
  Complexity      457      457              
============================================
  Files           247      247              
  Lines         11605    11606       +1     
  Branches       2177     2188      +11     
============================================
  Hits           2782     2782              
- Misses         8508     8509       +1     
  Partials        315      315              
Flag Coverage Δ
javascript 15.46% <ø> (ø)
php 59.53% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to backport? Prod has a border right as well

@st3iny
Copy link
Member Author

st3iny commented Jul 17, 2024

Yeah, it's safe to backport. I checked locally.

@st3iny
Copy link
Member Author

st3iny commented Jul 17, 2024

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jul 17, 2024
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 17, 2024
@st3iny st3iny enabled auto-merge July 17, 2024 15:06
@st3iny st3iny merged commit 98b3982 into main Jul 17, 2024
43 of 44 checks passed
@st3iny st3iny deleted the fix/fc/today-white-border branch July 17, 2024 16:08
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Related to design, interface, interaction design, UX, etc. Feature: Fullcalendar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Days in mothly view have tiny white border right/bottom
2 participants