Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if userId is null #6115

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

am97
Copy link
Contributor

@am97 am97 commented Jul 3, 2024

Fixes #6113

Signed-off-by: Andrés Maldonado <maldonado@codelutin.com>
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.08%. Comparing base (6bdbb85) to head (a123dc8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6115      +/-   ##
============================================
- Coverage     29.83%   24.08%   -5.75%     
+ Complexity      912      457     -455     
============================================
  Files           289      247      -42     
  Lines         13768    11534    -2234     
  Branches       2165     2165              
============================================
- Hits           4107     2778    -1329     
+ Misses         9346     8441     -905     
  Partials        315      315              
Flag Coverage Δ
javascript 15.56% <ø> (ø)
php 59.52% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst
Copy link
Member

/backport! to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jul 4, 2024
Copy link

backportbot bot commented Jul 4, 2024

The backport to stable4.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable4.7
git pull origin stable4.7

# Create the new backport branch
git checkout -b backport/6115/stable4.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a123dc80

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6115/stable4.7

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@hamza221 hamza221 merged commit 84b99b4 into nextcloud:main Jul 4, 2024
43 of 44 checks passed
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@miaulalala miaulalala added this to the v5.0.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-request A backport was requested for this pull request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar 4.7.9 breaks shares
5 participants