[stable3.5] fix(appointments): Rate limit config creation and booking #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abusing the appointment config endpoint can lead to additional server load. Sending bulks of booking requests can lead to mass notifications and emails and server load, too. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/appointments/rate-limit-config-creation-stable3.5
branch
from
dd0f551
to
f60459f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## stable3.5 #5683 +/- ##
=============================================
+ Coverage 20.29% 20.32% +0.02%
=============================================
Files 186 186
Lines 6342 6353 +11
Branches 1032 1037 +5
=============================================
+ Hits 1287 1291 +4
- Misses 5055 5062 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
changed the title
st3iny
approved these changes
Jan 10, 2024
hamza221
approved these changes
Jan 10, 2024
ChristophWurst
deleted the
fix/appointments/rate-limit-config-creation-stable3.5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #5680.
NcNotecard doesn't exist for nc/vue 5 so I simplified the HTML.