Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): harden assertions in view controllers #5386

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 1, 2023

No description provided.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added 3. to review Waiting for reviews technical debt labels Aug 1, 2023
@st3iny st3iny self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (32fa3fa) 22.71% compared to head (814980e) 22.74%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5386      +/-   ##
============================================
+ Coverage     22.71%   22.74%   +0.02%     
  Complexity      372      372              
============================================
  Files           237      237              
  Lines         11679    11684       +5     
  Branches       2270     2270              
============================================
+ Hits           2653     2657       +4     
- Misses         9026     9027       +1     
Flag Coverage Δ
javascript 13.95% <ø> (+<0.01%) ⬆️
php 65.47% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst merged commit 3e74078 into main Aug 1, 2023
40 checks passed
@ChristophWurst ChristophWurst deleted the chore/tests/harden-view-controller-assertions branch August 1, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants