Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Fastfile Loggers Compatible with MacOS #13735

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Make Fastfile Loggers Compatible with MacOS #13735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ end

desc "Release phase 2 for RC: checks, tag, upload gplay to playstore with values from build.gradle"
lane :RC_releasePhase2 do |options|
checkReleaseRequirements_RC()
checkReleaseRequirements_RC() # Not working with MacOS
info = androidVersion
promptVersion(info)
checkChangelog(info)
Expand All @@ -69,8 +69,8 @@ lane :RC_releasePhase2 do |options|
tag(info)
uploadToPlaystore_RC(info)
createGithubRelease_RC(info)
fdroidMergeRequest_RC(info)
createChangelogPullRequest_RC(info)
fdroidMergeRequest_RC(info) # Not working with MacOS
createChangelogPullRequest_RC(info) # Not working with MacOS
end

desc "Release phase 1: make gplay/generic for FINAL, then test it"
Expand Down Expand Up @@ -284,11 +284,11 @@ private_lane :tag do |options|
end

private_lane :disableLogger do
sh("sed -i s'#<bool name=\"logger_enabled\">false</bool>#<bool name=\"logger_enabled\">true</bool>#' ../app/src/main/res/values/setup.xml")
sh("sed -i '' -e 's#<bool name=\"logger_enabled\">false</bool>#<bool name=\"logger_enabled\">true</bool>#' ../app/src/main/res/values/setup.xml")
end

private_lane :enableLogger do
sh("sed -i s'#<bool name=\"logger_enabled\">true</bool>#<bool name=\"logger_enabled\">false</bool>#' ../app/src/main/res/values/setup.xml")
sh("sed -i '' -e 's#<bool name=\"logger_enabled\">true</bool>#<bool name=\"logger_enabled\">false</bool>#' ../app/src/main/res/values/setup.xml")
end

desc "Upload to play store (beta)"
Expand Down
Loading