Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BitmapUtils: Bitmap Handling and Image Processing for Modern APIs and Performance Enhancements #13700

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Onkar755
Copy link

@Onkar755 Onkar755 commented Oct 4, 2024

This PR introduces several improvements and optimizations across bitmap and image processing functions, addressing issue #13617 :

  1. Bitmap Decoding Update: Introduced ImageDecoder for Android 9 (API 28) and above, while maintaining backward compatibility with BitmapFactory for older versions.
  2. Refactor rotateImage(): Improved EXIF orientation handling and clarified code for readability.
  3. Refactor usernameToColor: Improved MD5 validation, optimized color generation, and enhanced code readability for better performance.

Testing

  • All existing unit and instrumented tests were run and passed successfully.

  • Please review the changes.
  • If needed, additional tests can be added based on review feedback.
  • Any suggestions or improvements are welcome as this is my first contribution to this repository.

This PR aligns with the contribution guidelines and addresses the issue as described.

…d above, and BitmapFactory for older versions.

Signed-off-by: Onkar Chavan <onkarvchavan2017@gmail.com>
…bility.

Signed-off-by: Onkar Chavan <onkarvchavan2017@gmail.com>
…ration, and enhance readability.

Signed-off-by: Onkar Chavan <onkarvchavan2017@gmail.com>
@Onkar755 Onkar755 changed the title Improve BitmapUtils: Bitmap Handling and Image Processing for Modern APIs and Performance Enhancements #13617 Improve BitmapUtils: Bitmap Handling and Image Processing for Modern APIs and Performance Enhancements Oct 4, 2024
@joshtrichards joshtrichards added enhancement 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) performance 🚀 Performance improvement opportunities (non-crash related) labels Oct 4, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feedback-requested performance 🚀 Performance improvement opportunities (non-crash related) ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants