Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-groups #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevindorff
Copy link

This includes the content of the other existing PR, as those changes were necessary for me. That PR changed the version to 2.1.1, so I've versioned this one 2.1.2.

Additional changes in my code:

  • This pulls the correct configuration key when obtaining the group patterns, httpservlet_transaction_namer.name_grouper.patterns. The existing code is using the obfuscation patterns key.
  • This applies the parameter appending FIRST, so group patterns can use them.
  • I simplified the logic of parameter appending to just append the parameters to URI as grouping will want this and I don't see a reason why it shouldn't go to obfuscation, too.

I believe this now works as intended. Please let me know if I've misunderstood the function of the method.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants