Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support TTL in setJSON method #17

Merged
merged 3 commits into from
Jul 20, 2023
Merged

feat: support TTL in setJSON method #17

merged 3 commits into from
Jul 20, 2023

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Jul 19, 2023 •
edited
Loading

Which problem is this pull request solving?

In #10 we've introduced support for a ttl parameter in the set method. This PR extends that to the setJSON method.

It also includes a couple of small random changes:

  • Simplify the error message returned from the store, to avoid exposing weird XML coming from S3 (74156d6)
  • Simplify the method handling, removing the redundant finalMethod variable (181830e)

@eduardoboucas eduardoboucas requested a review from a team as a code owner July 19, 2023 19:59
@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited
Loading

✅ Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 181830e
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/64b841faecbf660008d19e40
😎 Deploy Preview https://deploy-preview-17--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 19, 2023
@eduardoboucas eduardoboucas merged commit 392c9e1 into main Jul 20, 2023
15 checks passed
@token-generator-app token-generator-app bot mentioned this pull request Jul 20, 2023
Merged
@eduardoboucas eduardoboucas deleted the feat/simplify-error branch October 24, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skn0tt Skn0tt Skn0tt approved these changes

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoboucas @Skn0tt