Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let BlockFilter exit if ckb has received exit signal #4641

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Let BlockFilter exit if ckb has received exit signal #4641

merged 2 commits into from
Sep 13, 2024
+5 −0

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • BlockFilter should exit if ckb has received exit signal

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner September 11, 2024 12:00
@eval-exec eval-exec requested review from doitian and removed request for a team September 11, 2024 12:00
@eval-exec
Let BlockFilter exit if ckb has received exit signal
4987fb8 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/fix-block-filter-exit-signal branch from a305651 to 4987fb8 Compare September 12, 2024 03:38
@eval-exec
Copy link
Collaborator Author

@doitian Can we add this change to v0.118.x?

@eval-exec eval-exec mentioned this pull request Sep 12, 2024
Merged
@eval-exec
Copy link
Collaborator Author

Should be merged into next v0.118.1 release.

@quake quake added this pull request to the merge queue Sep 13, 2024
Merged via the queue into nervosnetwork:develop with commit b314c85 Sep 13, 2024
31 checks passed
@eval-exec eval-exec deleted the exec/fix-block-filter-exit-signal branch September 25, 2024 16:13
@doitian doitian mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang approved these changes

@driftluo driftluo driftluo approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eval-exec @chenyukang @driftluo @quake @zhangsoledad