Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(script): add current_memory syscall #4063

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

mohanson
Copy link
Contributor

@mohanson mohanson commented Jul 6, 2023

What problem does this PR solve?

Problem Summary:

There is no way to get peak memory in the script.

What is changed and how it works?

What's Changed:

Add a new syscall current_memory which returns the peak memory.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

Note: Add a note under the PR title in the release note.

@mohanson mohanson requested a review from a team as a code owner July 6, 2023 06:46
@mohanson mohanson requested review from zhangsoledad and removed request for a team July 6, 2023 06:46
@mohanson mohanson changed the title feat(script): add peak_memory syscall feat(script): add current_memory syscall Jul 6, 2023
@eval-exec
Copy link
Collaborator

eval-exec commented Jul 6, 2023

The CI job for cargo-deny has failed, but it has been resolved in the develop branch.

@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Jul 6, 2023
auto-merge was automatically disabled July 6, 2023 23:54

Head branch was pushed to by a user without write access

@mohanson
Copy link
Contributor Author

mohanson commented Jul 7, 2023

The CI job for cargo-deny has failed, but it has been resolved in the develop branch.

CI failed on macOS now. Some unittest cases panics.

@eval-exec
Copy link
Collaborator

eval-exec commented Jul 7, 2023

test_collision_and_send_missing_indexes failed. I'm investigating this...
image

I'm trying to reproduce this in my host (Linux):

while true;
  do cargo test -p ckb-sync -p ckb-chain \
  relayer::tests::block_transactions_process::test_collision_and_send_missing_indexes \
  -- --nocapture;
done

@chenyukang and I can't reproduce this. Try to rerun the failed CI job...

@zhangsoledad zhangsoledad added this pull request to the merge queue Jul 10, 2023
Merged via the queue into nervosnetwork:develop with commit 758d4e5 Jul 10, 2023
33 checks passed
@mohanson mohanson deleted the get_peak_memory branch July 10, 2023 09:21
@doitian doitian mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Type: Feature, refactoring.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants