-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI workflow and examples tests #1228
Conversation
I fixed some typos and errors I introduced in the yaml files, now the pipeline fails as expected on the factory-contract, I'll check later when test small examples finishes if that's still working properly as I didn't really modify it, I reverted the changes I made. As for the factory-contract error I really don't know much about this so I would appreciate any help. |
Ok, I found a workaround by running status-message before factory-contract as it seems it needs it to be built before. Now the tests are running but there seems to be an error in the non-fungible-token regarding an unused trait, but this already seems a bit out of scope in regards to the original issue. I wait for any feedback on how this should be handled. |
@renzobanegass Add |
I also added it to the |
Just in case it helps with this, I added some logging to the failing ExecutionOutcome { transaction_hash: 9fjyUL5SkSqJFkaJwJNppiyk3DdQMnKN7LcZ3ZyTaE6s, block_hash: 3jmU8jDcEcJHERGBNMaSB43Xn6D2yD5kfUPz5RsKE5iy, logs: [], receipt_ids: [Ea5yKjwAAbfFnVp73QYVQtVTdX6TfWVszDnztrtBMCUW], gas_burnt: NearGas { inner: 888137757690 }, tokens_burnt: NearToken { inner: 88813775769000000000 }, executor_id: AccountId("status-top-level-account-long-name"), status: Failure(ActionError(ActionError { index: Some(0), kind: AccountDoesNotExist { account_id: AccountId("status-top-level-account-long-name") } })) }, |
Could you, please, contribute to those places to recommend IterableMap instead? (It got available with the most recent release, which is why it is still not widely recommended - we did not catch all the places) |
Should I change the LookupMap to an IterableMap instead? |
Yes, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renzobanegass I'd like to also invite you to join @race-of-sloths. Just mention the bot in a GitHub comment. Here is how it looks: #1230 (comment)
@race-of-sloths include this PR please |
@renzobanegass Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 3! Another weekly streak completed, well done @renzobanegass! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
🔄 The PR has been merged@frol, please score the PR with |
@race-of-sloths score 3 |
🌟 Score recorded!@frol, thank you for scoring this pull request in the Race of Sloths! |
Summary
Issue #1190
This PR addresses the following issues:
.wasm
files are built before running tests by updating CONTRIBUTING.md.examples/non-fungible-token
andexamples/versioned
.Changes
.github/workflows/test_examples_small.yml
and.github/workflows/test_examples.yml
to build and test more examples.examples/non-fungible-token
andexamples/versioned
in their Cargo.toml.UnorderedMap
withLookupMap
inexamples/versioned
.Testing
All tests have been run locally and pass successfully. In exception for the factory-contract tests. Also the CI has been modified and we need to check which errors come up when the pipeline runs.
LookupMap
Regarding this change I found that LookupMap is a suitable replacement for UnorderedMap based on the NEAR SDK documentation and the NEAR collections overview.
Key Points from Documentation:
LookupMap Features:
UnorderedMap Deprecation: