Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError: Dislike Button #314

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ hugovk
ids1024
williamroot
trygveaa
itsreallyfather
4 changes: 2 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ get certain attributes:
>>> video.viewcount, video.author, video.length
(1916, 'PyCon 2014', 10394)

>>> video.duration, video.likes, video.dislikes
('02:53:14', 25, 0)
>>> video.duration, video.likes
('02:53:14', 25)

>>> print(video.description)
Speaker: Richard Jones
Expand Down
1 change: 0 additions & 1 deletion pafy/backend_internal.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def _fetch_gdata(self):
self._username = uni(snippet['channelTitle'])
statistics = item["statistics"]
self._likes = int(statistics["likeCount"])
self._dislikes = int(statistics["dislikeCount"])
self._have_gdata = 1


Expand Down
9 changes: 0 additions & 9 deletions pafy/backend_shared.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def __init__(self, video_url, basic=True, gdata=False,

self._description = None
self._likes = None
self._dislikes = None
self._category = None
self._published = None
self._username = None
Expand Down Expand Up @@ -317,14 +316,6 @@ def likes(self):

return self._likes

@property
def dislikes(self):
""" The number of dislikes for the video. Returns int. """
if not self._dislikes:
self._fetch_basic()

return self._dislikes

@property
def mix(self):
""" The playlist for the related YouTube mix. Returns a Playlist object. """
Expand Down
1 change: 0 additions & 1 deletion pafy/backend_youtube_dl.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def _fetch_basic(self):
self._length = self._ydl_info['duration']
self._viewcount = self._ydl_info['view_count']
self._likes = self._ydl_info.get('like_count', 0)
self._dislikes = self._ydl_info.get('dislike_count', 0)
self._username = self._ydl_info['uploader_id']
self._category = self._ydl_info['categories'][0] if self._ydl_info['categories'] else ''
self._bestthumb = self._ydl_info['thumbnails'][0]['url']
Expand Down
1 change: 0 additions & 1 deletion pafy/playlist.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ def get_playlist(playlist_url, basic=False, gdata=False,
likes=allinfo.get('likes'),
title=allinfo.get('title'),
author=allinfo.get('author'),
dislikes=allinfo.get('dislikes'),
description=allinfo.get('description'),
items=[]
)
Expand Down