Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop pre task #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add drop pre task #26

wants to merge 4 commits into from

Conversation

mpanarin
Copy link
Owner

Closes #23

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.64%. Comparing base (f3e8e34) to head (b95de72).

Files Patch % Lines
lib/Tasks/mix_bump.ex 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   78.53%   78.64%   +0.10%     
==========================================
  Files          17       17              
  Lines         205      206       +1     
==========================================
+ Hits          161      162       +1     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpanarin
Copy link
Owner Author

@kaharlichenko please try this version if it properly fits your purpose.
You should be able to bump from 1.2.0-alpha to 1.2.0 via mix bump next.
Feel free to ping me here if anything is wrong.

Beware of some breaking changes from the latest release https://github.com/mpanarin/versioce/blob/master/docs/migrations.md#migrating-from--300

@kaharlichenko
Copy link

Thank you for the update. I played with this version and indeed I can change from 1.2.0-alpha to 1.2.0 via mix bump next.

On the other hand the next bumping mode is somewhat confusing.

Based on its name I would assume that it always advances the version. This doesn't seem to be the case, at least with respect to Semantic Versioning 2.0.0.

Here are the test cases that I ran:

Initial Version Command Run Resulting Version Advances (per semver)?
0.1.2 mix bump next --pre alpha 0.1.2-alpha 👎
0.1.2-alpha mix bump next --pre beta 0.1.2-beta 👍
0.1.2-beta mix bump next --pre alpha 0.1.2-alpha 👎
0.1.2-alpha mix bump next --pre alpha 0.1.2-alpha 👎
0.1.2-alpha mix bump next 0.1.2 👍

What I'm trying to say is that on one hand it handles my particular use case. On the other hand the naming next might be confusing for users as it doesn't guarantee that the version is going to be advanced, rather changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support use case for bumping from a pre-release version to a normal one
2 participants