Make up go brrrrrrrr #22781
Open
Make up go brrrrrrrr #22781
+438
−307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
force-pushed
the
dev-mode-next
branch
2 times, most recently
from
fd69245
to
b6ec560
Compare
KevinMind
force-pushed
the
dev-mode-next
branch
3 times, most recently
from
04cff9a
to
5ca1211
Compare
data seed command synchronizes storage directory Remove storage volume (reuse olympia volume) Remove data_olympia (use anonymous volume) Remove sources from development DOCKER_TARGET Invert docker-compose.ci to docker-compose.dev (update defaults in setup script to support prod mode in ci)
KevinMind
force-pushed
the
dev-mode-next
branch
from
5ca1211
to
5368572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15066
Fixes: mozilla/addons#15046
Description
This PR cuts out most of the remaining slowness from make up in development mode by:
Context
With this PR make up in dev mode will be much more efficient, though slightly different than production mode. Running in production mode is now trivial so this is probably an okay tradeoff. If you want to verify a feature or develop like you're in prod, you can do so. But we will save a lot of time by making up fast.
This PR also fixes race conditions we had during docker build by:
Testing
Run make up in development and production mode by specigying the docker target
You should be able to:
Seeding
This PR also fixes a bug where seeding the db does not synchronize the storage with the db state. Now it does. So running
Should clear the DB, seed it and sync the data and storage directories.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.