Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Button Behaviour When enable-submissions Flag is Disabled #22779

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

chrstinalin
Copy link
Contributor

@chrstinalin chrstinalin commented Oct 17, 2024

Fixes: mozilla/addons#15090

Description

when enable-submissions is disabled, now:

  1. Disables the 'create a theme' button
  2. Addon submission buttons are disabled and a warning is displayed directly under them with the flag note.

image
image

Testing

  1. Deactivate the enable-submissions waffle flag (everyone should be = True by default).
  2. User should be unable to make new submissions and warned via the disabled button.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.

@chrstinalin chrstinalin marked this pull request as draft October 17, 2024 18:47
@chrstinalin chrstinalin requested review from a team and KevinMind and removed request for a team October 17, 2024 19:56
@KevinMind
Copy link
Contributor

@chrstinalin could you reassign review. I'll be on PTO next week and don't want to block you.

@chrstinalin chrstinalin requested review from a team, KevinMind and eviljeff and removed request for KevinMind and a team October 18, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Submissions Waffle Flag Follow-up
2 participants