Merge pull request #123 from moov-io/issues-121

changed highest credit
moov-io · Oct 11, 2022 · 35e3f33 · 35e3f33
2 parents 0d4db63 + fe3201f
commit 35e3f33
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 13 deletions.
diff --git a/pkg/client/docs/BaseSegment.md b/pkg/client/docs/BaseSegment.md
@@ -54,7 +54,7 @@ Name | Type | Description | Notes
 
 ### NewBaseSegment
 
-`func NewBaseSegment(recordDescriptorWord int32, identificationNumber string, consumerAccountNumber string, accountType string, highestCredit int32, termsDuration string, accountStatus string, paymentHistoryProfile string, currentBalance int32, dateAccountInformation time.Time, surname string, firstName string, socialSecurityNumber int32, dateBirth time.Time, ecoaCode string, firstLineAddress string, state string, zipCode string, ) *BaseSegment`
+`func NewBaseSegment(recordDescriptorWord int32, identificationNumber string, consumerAccountNumber string, accountType string, termsDuration string, accountStatus string, paymentHistoryProfile string, currentBalance int32, dateAccountInformation time.Time, surname string, firstName string, socialSecurityNumber int32, dateBirth time.Time, ecoaCode string, firstLineAddress string, state string, zipCode string, ) *BaseSegment`
 
 NewBaseSegment instantiates a new BaseSegment object
 This constructor will assign default values to properties that have it defined,

diff --git a/pkg/client/model_base_segment.go b/pkg/client/model_base_segment.go
diff --git a/pkg/lib/base_segment.go b/pkg/lib/base_segment.go
@@ -121,7 +121,7 @@ type BaseSegment struct {
 	//  Revolving = Highest amount of credit utilized by the consumer
 	//
 	// For companies who report returned checks, such as collection agencies, report the original amount of the check, excluding fees and interest.
-	HighestCredit int `json:"highestCredit" validate:"required"`
+	HighestCredit int `json:"highestCredit,omitempty"`
 
 	// Contains the duration of credit extended.
 	//

diff --git a/pkg/lib/specifications.go b/pkg/lib/specifications.go
@@ -31,7 +31,7 @@ var (
 		"AccountType":                   {73, 2, alphanumeric, required},
 		"DateOpened":                    {75, 8, date, required},
 		"CreditLimit":                   {83, 9, numeric | zeroFill, applicable},
-		"HighestCredit":                 {92, 9, numeric, required},
+		"HighestCredit":                 {92, 9, numeric | zeroFill, nullable},
 		"TermsDuration":                 {101, 3, alphanumeric, required},
 		"TermsFrequency":                {104, 1, alphanumeric, applicable},
 		"ScheduledMonthlyPaymentAmount": {105, 9, numeric, applicable},
@@ -81,7 +81,7 @@ var (
 		"AccountType":                   {67, 2, alphanumeric, required},
 		"DateOpened":                    {69, 5, packedDate, required},
 		"CreditLimit":                   {74, 5, packedNumber | zeroFill, applicable},
-		"HighestCredit":                 {79, 5, packedNumber, required},
+		"HighestCredit":                 {79, 5, packedNumber | zeroFill, nullable},
 		"TermsDuration":                 {84, 3, alphanumeric, required},
 		"TermsFrequency":                {87, 1, alphanumeric, applicable},
 		"ScheduledMonthlyPaymentAmount": {88, 5, packedNumber, applicable},