Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/apple express piwoo 319 #949

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

mmaymo
Copy link
Collaborator

@mmaymo mmaymo commented Oct 11, 2024

Handles PIWOO-319

resources/js/blocks/ApplePayButtonComponent.js Outdated Show resolved Hide resolved
resources/js/blocks/ApplePayButtonComponent.js Outdated Show resolved Hide resolved
resources/js/blocks/ApplePayButtonComponent.js Outdated Show resolved Hide resolved
resources/js/blocks/ApplePayButtonComponent.js Outdated Show resolved Hide resolved
resources/js/blocks/ApplePayButtonComponent.js Outdated Show resolved Hide resolved
@@ -3,6 +3,8 @@
}
.apple-pay-button {
display: inline-block;
width: 100%;
height: 41px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to set the button height?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now i understood better the requirements of the button styling, but let me know if you see way to improve.

Copy link
Collaborator

@inpsyde-maticluznar inpsyde-maticluznar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Please verify if the button sizes are ok.

@@ -49,21 +49,24 @@ import ApplePayButtonComponent from './blocks/ApplePayButtonComponent'
gatewayData.forEach(item => {
let register = () => registerPaymentMethod(molliePaymentMethod(useEffect, ajaxUrl, filters, gatewayData, availableGateways, item, jQuery, requiredFields, isCompanyFieldVisible, isPhoneFieldVisible));
if (item.name === 'mollie_wc_gateway_applepay' && !isBlockEditor) {
const isExpressEnabled = item.isExpressEnabled;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a new variable has the same name as the object property, you can do just that:

const {isExpressEnabled} = item;

Comment on lines 61 to 62
content: < ApplePayButtonComponent />,
edit: < ApplePayButtonComponent />,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra space can cause problems. Do these components still work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants