Add floating point support #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! The only note I have is that I'd like the name of the float type in mirth be:
Once that is renamed, I think it would be ok to merge this PR, even without single-precision! |
Everything's renamed, and I made the internal value be a float instead of storing as a string. Still figuring out why the windows build suddenly can't find |
Co-authored-by: typeswitch-dev <typeswitch@protonmail.com>
Co-authored-by: typeswitch-dev <typeswitch@protonmail.com>
|
Thanks @casuallyblue! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial steps of floating point support for mirth. I'm uploading it before it is completely done for feedback before I implement any further. This includes a partial implementation of a mandelbrot set renderer example.