Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding language support for JS/TS via typescript-language-server #6

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

themichaelusa
Copy link

@themichaelusa themichaelusa commented Oct 9, 2024

This is still a work in progress, but should be ready to go in no more than a day.

TODOs:

  • Revert changes to pyproject.toml
  • Remove junk files from my fork (todo.txt, tests_js, etc)
  • Proper tests for JS/TS integration under multilspy/tests
  • Some code styling nits + comments where needed
  • Revert event loop changes (these are for a separate PR - assuming I can replicate hanging behavior w/ SyncLanguageServer)

@themichaelusa
Copy link
Author

@microsoft-github-policy-service agree company="Rubrick, Inc."

@mrT23
Copy link

mrT23 commented Oct 15, 2024

I think i solved the problem described here:
#5 (comment)

see attached file:
initialize_params.json

I basically removed the window section from the capabilities. I don't think it is needed for our API usage, and it causes the stuck problem

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants