Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text scale support on TextBox and NavigationView buttons #9644

Open
wants to merge 3 commits into
base: winui2/main
Choose a base branch
from

Conversation

United600
Copy link

@United600 United600 commented May 19, 2024

Some TexBlocks with glyphs don't properly ignore the system text accessibility setting and, for the NavigationView search button, can scale beyond the control limits. The design guidance.

Description

  • Disable IsTextScaleFactorEnabled on the NavigationViewPaneSearchButtonStyle, ported back from WinUI 3.

    <Setter Property="IsTextScaleFactorEnabled" Value="False" />

  • Disable IsTextScaleFactorEnabled on the RevealButtonstyle for the PasswordBox control.

  • Disable IsTextScaleFactorEnabled on the DeleteButtonStyle for the TextBox/NumberBox/PasswordBox/AutoSuggestBox controls

Motivation and Context

Provide better accessibility text size support.

How Has This Been Tested?

Created a test app WinUI 2 with and without the changes.

Screenshots (if appropriate):

Before (IsTextScaleFactorEnabled="True") After (IsTextScaleFactorEnabled="False")
ClearButtonBefore ClearButton
RevealBefore Reveal

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label May 19, 2024
@United600
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue needs to be triaged by the area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant