Fix Slot Validation for Custom Proc #712
Open
+912
−368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/custom-proc-cluster
branch
4 times, most recently
from
e52db1e
to
6740fc8
Compare
Xizt
reviewed
Oct 14, 2024
| @@ -172,6 +175,13 @@ internal bool RunTransactionProc(byte id, ArgSlice input, CustomTransactionProce | |||
| return false; | |||
| } | |||
|
|
|||
| if (state == TxnState.Aborted) | |||
There was a problem hiding this comment.
I'm wondering if there should another state (CROSSLOTABORT?) when slot verification fails.
There was a problem hiding this comment.
It is not difficult to add but how is this useful? When txn is aborted the client will receive a message that validation failed due slot verification issue.
There was a problem hiding this comment.
Currently, transaction fail possible only due to slot verification issue. Can there be more reasons later? If yes, it would keep showing slot verification issue hence thought of another state.
vazois
force-pushed
the
vazois/custom-proc-cluster
branch
from
fce109d
to
d51994c
Compare
vazois
force-pushed
the
vazois/custom-proc-cluster
branch
from
1f564b8
to
e9884d5
Compare
badrishc
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes slot verification for custom proc.
It introduces the following:
RespClusterBench
RespClusterDisableSlotVerificationBench